Review Request: konqueror: reset URL when pressing ESC in address bar

[Dawit A]

On Tue, Jun 21, 2011 at 2:23 PM, David Faure <faure at kde.org> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6681/
>
> OK for url() then.
>
> Re the code above, you're probably right, it wasn't tested with Ctrl+Shift+Tab, only with Ctrl+Tab.
>
>
>    /trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp<http://svn.reviewboard.kde.org/r/6681/diff/3/?file=46513#file46513line3143> (Diff
> revision 3)
>
> bool KonqMainWindow::eventFilter(QObject*obj, QEvent *ev)
>
>    3143
>
>           m_combo->setURL(url.prettyUrl().startsWith(QLatin1String("about:")) ? "" : url.pathOrUrl());
>
>   This should be url.protocol() == QLatin1String("about") :-)
>
> Yes, it is better to do what David suggests. Unfortunately checking for
"about" that does not address the problem.

The URL restored needs to be what was originally entered when the page was
rendered. For example, if I typed "about:plugins" to view the available
plugins, then typed another address and pressed escape, the address I expect
to see is "about:blank" and not a blank location bar, which unfortunately is
what this patch will result in.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110621/bf08d93f/attachment.htm>