Review Request: Adds KIconLoader::drawOverlays which allows to draw overlays on any pixmap.

David Faure faure at kde.org
Tue Jun 21 13:37:27 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101569/#review4057
-----------------------------------------------------------

Ship it!


Looks ok.

- David


On June 10, 2011, 7:38 p.m., Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101569/
> -----------------------------------------------------------
> 
> (Updated June 10, 2011, 7:38 p.m.)
> 
> 
> Review request for kdelibs, David Faure and Michael Pyne.
> 
> 
> Summary
> -------
> 
> This method uses KIconLoaderPrivate::drawOverlays which is also modified by this patch, to take both width and height of the pixmaps into consideration.
> 
> I plan to utilize this method both in the Dolphin Information Panel and in KFilePreviewGenerator.
> 
> 
> Diffs
> -----
> 
>   kdeui/icons/kiconloader.h c29c12e 
>   kdeui/icons/kiconloader.cpp bcb7b69 
> 
> Diff: http://git.reviewboard.kde.org/r/101569/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matthias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110621/242aa0c6/attachment.htm>


More information about the kde-core-devel mailing list