Review Request: add some "currentView" 0-pointer checks in konqueror/src/konqmainwindow.cp

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101586/#review4036
-----------------------------------------------------------


Looks good, but can you also add Q_ASSERT(m_currentView) before the if (!m_currentView) checks so that in debug mode this will assert. The view should not be null and if it is someone needs to figure out why that is the case.

- Dawit


On June 11, 2011, 6:56 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101586/
> -----------------------------------------------------------
> 
> (Updated June 11, 2011, 6:56 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Summary
> -------
> 
> add some "currentView" 0-pointer checks in konqueror/src/konqmainwindow.cpp to avoid crashes like #272557
> 
> 
> This addresses bug 272557.
>     http://bugs.kde.org/show_bug.cgi?id=272557
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqmainwindow.cpp a309f48 
> 
> Diff: http://git.reviewboard.kde.org/r/101586/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110619/7a7b94d1/attachment.htm>