Review Request: New API in KIO Scheduler for setting internal meta-data...

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101677/
-----------------------------------------------------------

(Updated June 19, 2011, 6:52 p.m.)


Review request for kdelibs, Andreas Hartmetz and David Faure.


Changes
-------

Updated API documentation. More specially the new API addition of KIO::Scheduler is going to be part of stable v4.6.5 release.


Summary (updated)
-------

Currently the internal KIO metdata sent by an ioslave is not passed onto the other ioslaves until the originating ioslave emits its finished signal. Unfortunately, this has a side effect in that if the client application makes another request before the original ioslave is done, the internal meta-data information might not be sent to the new ioslave that would be created to service this new request.

This deficiency in the previous implementation of internal meta-data causes multiple address spoofing warning prompts when you use a kdewebkit based browser, e.g. konqueror + kwebkitpart or reKonq. That is because QtWebKit automatically starts retrieving script and css files in the background before the original site is downloaded completely.


Diffs (updated)
-----

  kio/kio/job.cpp 904604b 
  kio/kio/scheduler.h f416e6a 
  kio/kio/scheduler.cpp 4ef66b3 

Diff: http://git.reviewboard.kde.org/r/101677/diff


Testing
-------


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110619/775bf43a/attachment.htm>