Review Request: [PATCH] Change HTML thumbnail generator to use kdewebkit to fix bug 248478

Albert Astals Cid aacid at kde.org
Wed Jun 15 18:45:18 BST 2011


A Wednesday, June 15, 2011, Sebastian K├╝gler va escriure:
> On Friday, June 03, 2011 20:53:43 Dawit A wrote:
> > Do you have any plans for pushing this into git master/KDE 4.6 branch
> > ? Either your patch or mine needs to make it into KDE 4.7.
> 
> I'd prefer Dawit's patch, since it will also work with the leaner mobile
> build profile, and HTML thumbnail generation is especially useful (and
> wanted) in those cases.

I'd prefer one that is less invasive/prone to break as possible (given how 
late we are in the release process) and without having a look at any of the 
patches it seems Dawit's is more invasive/prone to break as it involves 
changing the renderer altogether.

Albert




More information about the kde-core-devel mailing list