Review Request: Do not change Konqueror's tab icon on invalid url

Dawit Alemayehu adawit at kde.org
Wed Jun 15 06:02:54 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101626/
-----------------------------------------------------------

Review request for KDE Base Apps.


Summary
-------

Do not change the tab icon when switching between tabs, if the location bar url is invalid, e.g. blank. To duplicate the problem simply empty the location bar and switch tabs. The tab you switched from will get the generic folder icon.


This addresses bug 131909.
    http://bugs.kde.org/show_bug.cgi?id=131909


Diffs
-----

  konqueror/src/konqview.cpp efd7f07 

Diff: http://git.reviewboard.kde.org/r/101626/diff


Testing
-------


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110615/7eabe1de/attachment.htm>


More information about the kde-core-devel mailing list