Review Request: add default help menu with all standard help actions to Help button in KFind

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101443/#review3869
-----------------------------------------------------------

Ship it!


Looks OK. Perhaps KFind should actually have a main window with a normal menu bar instead of being a dialog, but that's unrelated to this patch. Please remember to update the 4.6.5 changelog.


kfind/kfinddlg.cpp
<http://git.reviewboard.kde.org/r/101443/#comment3166>

    Extra whitespace.


- Raphael


On May 26, 2011, 12:07 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101443/
> -----------------------------------------------------------
> 
> (Updated May 26, 2011, 12:07 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Summary
> -------
> 
> The Help button in KFind opens the Handbook, but all usual standard help actions like bug report, switch language and about kde/kfind are missing. Wth this patch the Help in kfind has the default behavior of all other kde applications. ksnaphot has the same button with all standard help actions.  
> 
> 
> This addresses bug 132630.
>     http://bugs.kde.org/show_bug.cgi?id=132630
> 
> 
> Diffs
> -----
> 
>   kfind/kfinddlg.cpp 8645c0d 
> 
> Diff: http://git.reviewboard.kde.org/r/101443/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Burkhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110613/9bcb9d51/attachment.htm>