Review Request: Add missing actions to report bug + switch language to Help menu in dolphin whithout menubar
Peter Penz
peter.penz19 at gmail.com
Mon Jun 13 12:21:26 BST 2011
> On June 12, 2011, 9:49 p.m., Peter Penz wrote:
> > Thanks for the patch! I completely missed this entry (I rarely report Dolphin bugs this way ;-))...
>
> Albert Astals Cid wrote:
> I know this is "off topic" for this review request but shouldn't this code be using a KHelpMenu? By doing that you'll avoid missing some entries
Thanks for the hint - yes, that would be better. I've added this to my TODO-list - I'm currently busy with some other things but won't forget about this.
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101597/#review3852
-----------------------------------------------------------
On June 12, 2011, 8:21 p.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101597/
> -----------------------------------------------------------
>
> (Updated June 12, 2011, 8:21 p.m.)
>
>
> Review request for KDE Base Apps and Peter Penz.
>
>
> Summary
> -------
>
> Using Dolphin in default mode in master /4.7.) whithout menubar the user has no actions to report a bug or switch language. Patch adds this to the Help menu launched from the toolbar button Configure and control Dolphin.
>
>
> Diffs
> -----
>
> dolphin/src/dolphinmainwindow.cpp 198e2da
>
> Diff: http://git.reviewboard.kde.org/r/101597/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Burkhard
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110613/25d46471/attachment.htm>
More information about the kde-core-devel
mailing list