Review Request: Return the url of the view instead of the url of the url navigator.

Peter Penz peter.penz19 at gmail.com
Fri Jun 10 23:26:05 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101580/#review3833
-----------------------------------------------------------

Ship it!


Ah, very nice corner case :-) Patch is fine, thanks!

- Peter


On June 10, 2011, 10:11 p.m., Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101580/
> -----------------------------------------------------------
> 
> (Updated June 10, 2011, 10:11 p.m.)
> 
> 
> Review request for KDE Base Apps and Peter Penz.
> 
> 
> Summary
> -------
> 
> That way if a wrong protocol had been entered the currently watched directory will be returned.
> 
> 
> This addresses bug 274890.
>     http://bugs.kde.org/show_bug.cgi?id=274890
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinviewcontainer.cpp 1042ece 
> 
> Diff: http://git.reviewboard.kde.org/r/101580/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matthias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110610/c058fe17/attachment.htm>


More information about the kde-core-devel mailing list