Review Request: Use the port number in the filename when caching favicons

Dawit Alemayehu adawit at kde.org
Fri Jun 10 21:34:12 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101577/
-----------------------------------------------------------

Review request for KDE Base Apps.


Summary
-------

The attached patch uses the port number of a favicon's url when creating its local cache name. This helps distinguish two severs running on the same host as pointed out in the bug report listed above.


This addresses bug 124482.
    http://bugs.kde.org/show_bug.cgi?id=124482


Diffs
-----

  lib/konq/favicons/favicons.cpp 8ba9258 

Diff: http://git.reviewboard.kde.org/r/101577/diff


Testing
-------


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110610/014eb00b/attachment.htm>


More information about the kde-core-devel mailing list