Review Request: Show the correct url in Konqueror when switching to tabs after clearing location bar.

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101558/
-----------------------------------------------------------

Review request for KDE Base Apps.


Summary
-------

Show the correct url in Konqueror when switching to a new tab after clearing the url of the current tab. Right now if the location bar is cleared using the backspace key or the clear button before switching to another tab, the location bar will always be empty unless the views are reloaded.

The second issue, not addressed by this patch, is use of the wrong url on reload. To see this problem simply
1.) Open two tabs, enter a URL in one and let it finish loading. 
2.) Start changing the location bar url, but do not press return. 
3.) Switch view to the first tab and switch back. 
4.) Reload the page. 

The incorrect URL, newly typed and potentially invalid URL, will be used for the reload request. This issue is caused by a workaround for another bug (#54687) in KonqMainWindow::slotReload and requires its own fix.


This addresses bug 187891.
    http://bugs.kde.org/show_bug.cgi?id=187891


Diffs
-----

  konqueror/src/konqmainwindow.cpp a309f48 

Diff: http://git.reviewboard.kde.org/r/101558/diff


Testing
-------


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110609/c2addb69/attachment.htm>