Review Request: startkde.cmake should treat font dpi like kcontrol/krdb/krdb.cpp does

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101410/#review3703
-----------------------------------------------------------

Ship it!


Looks good. Do you want me to commit this for you, or do you want to get a kde contributor account instead, to be able to commit this directly as well as future patches? :)

- David


On June 1, 2011, 10:54 a.m., Lukas Sommer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101410/
> -----------------------------------------------------------
> 
> (Updated June 1, 2011, 10:54 a.m.)
> 
> 
> Review request for KDE Base Apps, KDE Runtime and kdelibs.
> 
> 
> Summary
> -------
> 
> I've been experimenting a little bit with custom font dpi sizes in $HOME/.kde4/share/config/kcmfonts
> 
> There, you can set custom font dpi value. Although the user interface (systemsettings/fonts) only provides 0 (don't force a dpi, use the system default instead), 96 and 120 as choice, in the config file you can put (manually) arbitrary values. This works mostly fine because kcontrol/krdb/krdb.cpp simply processes the dpi value of the config file "as is".
> 
> However, startkde.cmake doesn't. It checks if the value is 96 or 120. If not, the value is ignored and the system default is used.
> 
> Result: When you use e.g. 200 as dpi value and restart KDE, then KWin uses the default value (96 dpi on my system) for the window title, while the applications themself are displayed using 200 dpi. So the applications fonts are as big as desired, but the window title is too small. See the attached screenshot. This behaviour is inconsistent. startkde.cmake should follow the same police as kcontrol/krdb/krdb.cpp does. This patch fixes this.
> 
> (The user interface could be adopted in another patch.)
> 
> (Make this work would benefit people who need a high display resolution. Example: You connect your computer to your plasma tv and you want to be still be able to read the text although you are at a distance of 5 meters from the tv monitor. See also bug 272266)
> 
> 
> This addresses bug 190489.
>     http://bugs.kde.org/show_bug.cgi?id=190489
> 
> 
> Diffs
> -----
> 
>   kcontrol/fonts/fonts.h 2c722d4 
>   kcontrol/fonts/fonts.cpp 0cd2666 
>   startkde.cmake dde9c23 
> 
> Diff: http://git.reviewboard.kde.org/r/101410/diff
> 
> 
> Testing
> -------
> 
> I've applied the patch to my local /usr/bin/startkde file, and it works fine.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/101410/s/171/
> 
> 
> Thanks,
> 
> Lukas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110606/5eb50ee5/attachment.htm>