Review Request: Rebuild fake locale as soon as possible

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101509/#review3700
-----------------------------------------------------------

Ship it!


Looks good.

- David


On June 5, 2011, 12:23 a.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101509/
> -----------------------------------------------------------
> 
> (Updated June 5, 2011, 12:23 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> By calling locale() instead of d->locale we ensure we kill and rebuild the locale as soon as possible in the chain, since calling functions in klocale can end up calling kglobal::locale again that might kill the fake locale and then we end up in trouble because we just killed ourselves ( see backtrace in https://bugs.kde.org/show_bug.cgi?id=274169 )
> 
> 
> This addresses bug 274169.
>     http://bugs.kde.org/show_bug.cgi?id=274169
> 
> 
> Diffs
> -----
> 
>   kdecore/kernel/kglobal.cpp 45a6c5a 
> 
> Diff: http://git.reviewboard.kde.org/r/101509/diff
> 
> 
> Testing
> -------
> 
> vlc does not crash anymore. Other apps start fine.
> 
> 
> Thanks,
> 
> Albert
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110606/1239f25a/attachment.htm>