Review Request: a very little fix
Guy Maurel
guy-kde at maurel.de
Sat Jun 4 18:39:28 BST 2011
> On May 24, 2011, 5:33 p.m., Jaime Torres Amate wrote:
> > kdecore/config/kconfigdata.h, line 265
> > <http://git.reviewboard.kde.org/r/101433/diff/1/?file=18016#file18016line265>
> >
> > Even better, change it to log the previous value and the new one.
> > But look, it is commented.
yes it is commented, but if you want to use it, it is wrong/or at the wrong line. One line below would be right.
- Guy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101433/#review3485
-----------------------------------------------------------
On May 24, 2011, 4:17 p.m., Guy Maurel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101433/
> -----------------------------------------------------------
>
> (Updated May 24, 2011, 4:17 p.m.)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> corrected to the right variable
>
>
> Diffs
> -----
>
> kdecore/config/kconfigdata.h 0dff4ad
>
> Diff: http://git.reviewboard.kde.org/r/101433/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guy
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110604/85505b56/attachment.htm>
More information about the kde-core-devel
mailing list