Review Request: Two important KUrlCompletion fixes...

Dawit Alemayehu adawit at
Fri Jun 3 22:00:48 BST 2011

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs.


The attached patch fixes two long stand bugs in KUrlCompletion:

#1. No completion for executables when the mode is set to KUrlCompletion::ExeCompletion as reported in the bugs listed above.
#2. For every text completion request a new directory listing thread is unnecessarily created due to a logic error in KUrlCompletion::customEvent. This means that every keypress in the location bar of apps like Konqueror, Dolphin and the input box of Krunner results in the creation of a new thread directory lister, which of course is waste.

This addresses bugs 77169 and 116639.


  kio/kio/kurlcompletion.cpp 86aa9d3 



Made sure executable completion in KOpenWith dialog works correctly.
Made sure a directory lister thread is not created for every completion request (completion should be much faster).
Made sure the unit test class, kurlcompletiontest, passes with the fixes.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list