Review Request: Fix KComboBox KConfigXT bug when using qt 4.8

Jeremy Paul Whiting jpwhiting at kde.org
Wed Jun 1 20:29:36 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101486/
-----------------------------------------------------------

Review request for kdelibs and Eike Hein.


Summary
-------

QComboBox in qt 4.8 sets currentIndex as it's USER property.  Which breaks kconfigxt saving of kcombobox values as the text inside them.  I noticed this in konversation's timestampformat setting which was getting saved as 0, or 1 depending on the index of the combobox, rather than the text of the combobox.


Diffs
-----

  kdeui/dialogs/kconfigdialogmanager.cpp 0209f49 

Diff: http://git.reviewboard.kde.org/r/101486/diff


Testing
-------

This works here and shouldn't cause any problems even with qt 4.7 or so, just makes QComboBox special casing come before USER property checking rather than after.


Thanks,

Jeremy Paul

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110601/66a8b27a/attachment.htm>


More information about the kde-core-devel mailing list