Review Request: PATCH: Honor size and coordinates when creating new Konqueror windows

Wed Jun 1 04:33:51 BST 2011

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101477/
-----------------------------------------------------------

(Updated June 1, 2011, 3:33 a.m.)

Review request for KDE Base Apps and David Faure.

Changes
-------

Added a test case for anyone that wants to test the scenario outlined in the description section.

Summary
-------

Currently new window creation in KonqMainWindow::slotCreateNewWindow does not honor the supplied cooridnate and size information under certain circumstances. For example, if you click on a javascript link that opens a new window, then the new window will always be maximized, regardless of the size information supplied by the javascript window.open call, as long as the Konqueror window where you clicked on the link is also maximized. Even when the original window is not maximized, if you maximize and close the newly created window, then clicking on the javscript window.open link again will result in a maximized window.

The attached patch addresses all of the above issues by making sure the coordinate and size information are always honored during new window creation.

Diffs
-----

  konqueror/src/konqmainwindow.cpp 56aa379 

Diff: http://git.reviewboard.kde.org/r/101477/diff

Testing (updated)
-------

<html>
  <head>
    <title>Javascript window.open Test</title>
  </head>
  <body>
    <a href="javascript:window.open('about:blank', 'NewWindowTest1', 'width=300, height=400')">window.open test</a>
  </body>
</html>

Test #1:
=======
1.) Copy the HTML snippet above into a file and open it with konqueror.
2.) Maximize the Konqueror window.
3.) Click on the link.  
4.) Notice new window is opened maximized.

Test #2:
=======
5.) Repeat steps 2-4 above, but do not maximize the Konqueror window in step 2.
6.) The new window opened when you clicked on the link should be of correct size.
7.) Maximize this new window, then close it.
8.) Click on the javascript link again.
9.) Notice how the new window is opened maximized.

After applying the patch, none of the above test scenarios should be reproducible.

Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110601/da7b5e68/attachment.htm>