Review Request: Fix bug : now KDE widges are shown in Qt Designer

Artem Serebriyskiy v.for.vandal at gmail.com
Sat Jul 30 14:01:11 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101804/
-----------------------------------------------------------

(Updated July 30, 2011, 1:01 p.m.)


Review request for kdelibs.


Changes
-------

Could you please look at the following patch ? I think it is better the previous one, althougn not as straight forward. This way we depends less from any possible further changes in QDesignerCustomWidgetInterface.

But I can ship previous one, if you found it better.


Summary
-------

Qt designer requires that subclasses of QDesignerCustomWidgetInterface  return non-empty, valid XML in domXML() function. makewidges generated empty string in this function by default. Because of this, kde widges are not shown in qt designer. This patch fix this bug.


Diffs (updated)
-----

  kdewidgets/makekdewidgets.cpp cb53c04 

Diff: http://git.reviewboard.kde.org/r/101804/diff


Testing
-------

My system. Designer now see plugins generated with makewidges. Other plugins must be changed by their authors.


Thanks,

Artem

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110730/ef4d61d6/attachment.htm>


More information about the kde-core-devel mailing list