Review Request: Fix logic with clear-button animation in klineedit (notably at first try) and address bug 268898.

[Hugo Pereira Da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102095/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

Details:
- fixes the somewhat incorrect logic in KLineEditButton::animateVisible
- simplifies KLineEdit::updateClearButtonIcon consequently.


This addresses bug 268898.
    http://bugs.kde.org/show_bug.cgi?id=268898


Diffs
-----

  kdeui/widgets/klineedit.cpp 8f1c8a4 
  kdeui/widgets/klineedit_p.h 95016bd 

Diff: http://git.reviewboard.kde.org/r/102095/diff


Testing
-------

tested with klineedittest found in kdelibs/kdeui/tests, this with and without the patch attached to comment #1 of bug 268898, used to actually trigger the mentionned bug. Also tested with other klineEdit implementation such as Dolphin's location bar.


Thanks,

Hugo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110726/5fdac5d6/attachment.htm>