Review Request: Konqueror: Ask for session restore ONLY on plain startup (not for every window)

[Marcel Partap]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101850/#review4860
-----------------------------------------------------------


Uhhmm.. so can i commit this? David? .. (:

- Marcel


On July 4, 2011, 11:44 p.m., Marcel Partap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101850/
> -----------------------------------------------------------
> 
> (Updated July 4, 2011, 11:44 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Summary
> -------
> 
> This patch stops asking for session restore for EVERY new window (popups!) and does so ONLY when initial konqueror process is started, and called without URL. Because i didn't want to loose all my crashed sessions and the 'import crashed sessions as bookmarks' feature disappeared sometime, i had been clicking on 'ask again later' 42 bazillion times. Restoring all the crashed sessions always brought down the process (imho each session should restore as individual process, but that is another patch).
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqmain.cpp 218e708 
>   konqueror/src/konqmisc.cpp c46dc07 
> 
> Diff: http://git.reviewboard.kde.org/r/101850/diff
> 
> 
> Testing
> -------
> 
> Tryed out and traced everything with GDB, does as says. Finally no huge crashed-session-parsing-delay for every stupid popup ^^
> 
> 
> Thanks,
> 
> Marcel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110719/db204660/attachment.htm>