Re: Review Request: Make “Edit File Type” button more discoverable

[Aaron J. Seigo]

> On July 7, 2011, 12:26 p.m., Aaron J. Seigo wrote:
> > nice :) thanks for improving this ...
> 
> Kai Uwe Broulik wrote:
>     Oh, btw, I don’t have commit access.
> 
> Christoph Feck wrote:
>     Why not? It would help us if you can commit reviewed changes yourself. And having to deal with git can be fun ;)

indeed; if you want, i can commit this for you. but if you'd like to continue contributing, i'd suggest getting an account:

http://techbase.kde.org/Contribute/Get_a_Contributor_Account

and then you can push this change yourself! huzzah! :)


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101800/#review4495
-----------------------------------------------------------


On June 30, 2011, 10:34 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101800/
> -----------------------------------------------------------
> 
> (Updated June 30, 2011, 10:34 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> On IRC this evening somebody found it hard to find the options to edit a specific file type. The KCM is a mess unfortunately but I told him that you could edit specific file types directly from the properties dialog.
> That button is hard to spot, though, which I also often found annoying. It is neither labled nor does it stand out as “button”.
> This patch solves that issue.
> 
> It is in need of discussion whether the label itself should stay but the button definitly has to look like a clickable target.
> 
> Comparison screenshot: privat.broulik.de/filedialogpatch.png (this screenshot is from the initial attempt where i forgot the capitalization :P)
> 
> 
> Diffs
> -----
> 
>   kio/kfile/kpropertiesdialog.cpp 3382daa 
> 
> Diff: http://git.reviewboard.kde.org/r/101800/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kai Uwe
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110719/72a608a1/attachment.htm>