Review Request: Resize KMessageBox::detailedError at start to display all text
Burkhard Lück
lueck at hube-lueck.de
Wed Jul 13 16:01:31 BST 2011
> On July 12, 2011, 4:30 p.m., Albert Astals Cid wrote:
> > Have you run kdialog_unittest?
>
> Burkhard Lück wrote:
> $ make test
> Running tests...
> Test project /home/kdedev/svn/build/kdelibs/kdeui/tests
> Start 1: kdeui-kactioncollectiontest
> 1/39 Test #1: kdeui-kactioncollectiontest ........ Passed 0.19 sec
> Start 2: kdeui-kactioncategorytest
> 2/39 Test #2: kdeui-kactioncategorytest .......... Passed 0.15 sec
> Start 3: kdeui-kbuttongrouptest
> 3/39 Test #3: kdeui-kbuttongrouptest ............. Passed 0.49 sec
> Start 4: kdeui-kcompletioncoretest
> 4/39 Test #4: kdeui-kcompletioncoretest .......... Passed 0.04 sec
> Start 5: kdeui-kconfigguitest
> 5/39 Test #5: kdeui-kconfigguitest ............... Passed 0.11 sec
> Start 6: kdeui-kconfigskeletontest
> 6/39 Test #6: kdeui-kconfigskeletontest .......... Passed 0.04 sec
> Start 7: kdeui-kdualactiontest
> 7/39 Test #7: kdeui-kdualactiontest .............. Passed 0.12 sec
> Start 8: kdeui-kfadewidgeteffecttest
> 8/39 Test #8: kdeui-kfadewidgeteffecttest ........ Passed 0.08 sec
> Start 9: kdeui-kfindtest
> 9/39 Test #9: kdeui-kfindtest .................... Passed 0.08 sec
> Start 10: kdeui-kglobalsettingstest
> 10/39 Test #10: kdeui-kglobalsettingstest .......... Passed 0.24 sec
> Start 11: kdeui-kglobalshortcuttest
> 11/39 Test #11: kdeui-kglobalshortcuttest ..........***Failed 3.44 sec
> Start 12: kdeui-kmainwindow_unittest
> 12/39 Test #12: kdeui-kmainwindow_unittest ......... Passed 1.10 sec
> Start 13: kdeui-klineedit_unittest
> 13/39 Test #13: kdeui-klineedit_unittest ........... Passed 0.42 sec
> Start 14: kdeui-ktextedit_unittest
> 14/39 Test #14: kdeui-ktextedit_unittest ........... Passed 0.14 sec
> Start 15: kdeui-kcombobox_unittest
> 15/39 Test #15: kdeui-kcombobox_unittest ........... Passed 0.24 sec
> Start 16: kdeui-kdialog_unittest
> 16/39 Test #16: kdeui-kdialog_unittest ............. Passed 0.69 sec
> Start 17: kdeui-kreplacetest
> 17/39 Test #17: kdeui-kreplacetest ................. Passed 3.70 sec
> Start 18: kdeui-kshortcuttest
> 18/39 Test #18: kdeui-kshortcuttest ................ Passed 0.04 sec
> Start 19: kdeui-kstandardactiontest
> 19/39 Test #19: kdeui-kstandardactiontest .......... Passed 0.16 sec
> Start 20: kdeui-kstandardshortcuttest
> 20/39 Test #20: kdeui-kstandardshortcuttest ........ Passed 0.07 sec
> Start 21: kdeui-kuniqueapptest
> 21/39 Test #21: kdeui-kuniqueapptest ............... Passed 0.89 sec
> Start 22: kdeui-kwordwraptest
> 22/39 Test #22: kdeui-kwordwraptest ................ Passed 0.65 sec
> Start 23: kdeui-kapplication_unittest
> [snip]
>
> Albert Astals Cid wrote:
> Sorry, i did not mean kdialog_unittest i really meant ./kmessageboxtest (it is a interactive test so you have to check everything looks fine and press buttons to continue)
$ ./kmessageboxtest
SizeHint = 32 x 15
SizeHint = 32 x 15
SizeHint = 33 x 30
SizeHint = 33 x 30
1. returned 3 (Yes)
2. returned 4 (No)
3. returned 3 (Yes)
4. returned 4 (No)
5. returned 3 (Yes)
6. returned 2 (Cancel)
7. returned 5 (Continue)
8. returned 3 (Yes)
9. returned 4 (No)
10. returned 2 (Cancel)
11. returned 1 (Ok)
12. returned 1 (Ok)
13. returned 1 (Ok)
14. returned 1 (Ok)
15. returned 1 (Ok)
16. returned 1 (Ok)
17. returned 1 (Ok)
18. returned 1 (Ok)
19. returned 1 (Ok)
20. returned 3 (Yes)
Filling StringList...
Completed...
21. returned 4 (No)
22. returned 1 (Ok)
23. returned 1 (Ok)
24. returned 1 (Ok)
25. returned 1 (Ok)
I ran kmessageboxtest with current kdialog.cpp and patched kdialog.cpp
and see no difference.
Btw kmessageboxtest.cpp has no test case for KMessageBox::detailedError,
but a lot of additional test cases commented at the end.
I modified one of the commented tests for KMessageBox::detailedError with
a long text (same problem I found with kgpg) and added it locally as No 25.
- Burkhard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101931/#review4654
-----------------------------------------------------------
On July 12, 2011, 4:01 p.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101931/
> -----------------------------------------------------------
>
> (Updated July 12, 2011, 4:01 p.m.)
>
>
> Review request for kdelibs and Darío Andrés Rodríguez.
>
>
> Summary
> -------
>
> Quoting the BR:
> "When using KMessageBox::detailedError() it sometimes doesn't resize properly to
> show all the text"
> See kgpg error dialog without kdelibs patch. The text "your keyringxx" is cut off.
>
> Pressing Details button (kgpg error dialog without kdelibs patch after clicking details)
> resizes the dialog properly and all text is visible.
>
> Last screenshot (kgpg error dialog with kdelibs patch) shows the dialog after the start
> and before clicking the Deatils button, everything is properly readable.
>
> I commit this review request on behalf of Dario Andres (https://bugs.kde.org/show_bug.cgi?id=193097#c9)
>
>
> This addresses bug 193097.
> http://bugs.kde.org/show_bug.cgi?id=193097
>
>
> Diffs
> -----
>
> kdeui/dialogs/kdialog.cpp 32f5df0
>
> Diff: http://git.reviewboard.kde.org/r/101931/diff
>
>
> Testing
> -------
>
> Tested with kgpg error dialog, see third screenshot.
>
>
> Screenshots
> -----------
>
> kgpg error dialog without kdelibs patch
> http://git.reviewboard.kde.org/r/101931/s/200/
> kgpg error dialog without kdelibs patch after clicking details
> http://git.reviewboard.kde.org/r/101931/s/201/
> kgpg error dialog with kdelibs patch
> http://git.reviewboard.kde.org/r/101931/s/203/
>
>
> Thanks,
>
> Burkhard
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110713/731ec8ed/attachment.htm>
More information about the kde-core-devel
mailing list