Review Request: Changed KUrl::toLocalFile to use QUrl::path() instead QUrl::toLocalFile() on non-Windows platforms

Commit Hook null at kde.org
Tue Jul 12 16:33:00 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101906/#review4651
-----------------------------------------------------------


This review has been submitted with commit b66e59e16c5bd94772911f01b9517abb8f13658f by Dawit Alemayehu to branch KDE/4.7.

- Commit


On July 11, 2011, 4:12 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101906/
> -----------------------------------------------------------
> 
> (Updated July 11, 2011, 4:12 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> The attached patch changes KUrl::toLocalFile to use QUrl::path() when extracting the path from the current URL on non-Windows platforms so that KUrl would return the correct path when KUrl::toLocalFile is called on an absolute path url whose top level contains a ':', e.g. "file:///A:/".
> 
> 
> This addresses bug 194746.
>     http://bugs.kde.org/show_bug.cgi?id=194746
> 
> 
> Diffs
> -----
> 
>   kdecore/io/kurl.cpp acfc9a1 
> 
> Diff: http://git.reviewboard.kde.org/r/101906/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110712/f40f0a29/attachment.htm>


More information about the kde-core-devel mailing list