Review Request: fix #277269 Dolphin(Part) Detail/Tree view, highlighted selection paint glitch

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101924/#review4621
-----------------------------------------------------------


Thanks again for your investigations. Like for the previous patch: It would only make sense to push it to the 4.7 branch. In this case I'm a little bit concerned to backport such a non-trivial change, but I trust you here. Please do a careful testing especially with the Oxygen-style as this style is used by most people. After fixing the leak I'm fine if this patch gets pushed to the 4.7 branch.

- Peter


On July 11, 2011, 9:39 p.m., Marcel Partap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101924/
> -----------------------------------------------------------
> 
> (Updated July 11, 2011, 9:39 p.m.)
> 
> 
> Review request for KDE Base Apps, David Faure and Peter Penz.
> 
> 
> Summary
> -------
> 
> What was strange that background highlighting and actual item selection were drawn independently from each other and the bogus highlighting to the left of the item was not cleared... Now this one was a __REAL__ bitch to get dealt with, took me hours and hours bashing my head against the shell ^^
> ok now again the viewOptions is not only not the place to turn off background highlighting, but there it was even tried to ENABLE it :O
> turned out this so called QStyle::SH_ItemView_ShowDecorationSelected	documented as "When an item in an item view is selected, also highlight the branch or other decoration." is hard-coded on by DEFAULT in QCommonStyle and all inheriting from there so it requires a QProxyStyle to override the setting. While we have the opportunity, also set SH_ItemView_ArrowKeysNavigateIntoChildren for added joice of keyboard navigation (although strange effect comes up when being on a leaf and pressing Cursor::Right again - but with or without this setting, something with the selection handler...)
> ...now someone owes me CAKE for this one :D
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphindetailsview.cpp 0ce26df 
>   dolphin/src/views/dolphintreeview.h c037d41 
>   dolphin/src/views/dolphintreeview.cpp 64b66aa 
> 
> Diff: http://git.reviewboard.kde.org/r/101924/diff
> 
> 
> Testing
> -------
> 
> head-bashing
> 
> 
> Screenshots
> -----------
> 
> dolphin-treeview-selection-paint-fail
>   http://git.reviewboard.kde.org/r/101924/s/195/
> 
> 
> Thanks,
> 
> Marcel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110711/0ae60a2c/attachment.htm>