Review Request: fix for #277372 - dolphin part looses view state on every tab change

Marcel Partap mpartap at
Mon Jul 11 21:45:43 BST 2011

This is an automatically generated e-mail. To reply, visit:

Review request for KDE Base Apps, David Faure and Peter Penz.


At the point where m_viewModeController->setUrl(url) was invoked in current code, the view does not yet exist because it is only created in applyViewProperties(). Moving the call after view creation is not enough however. The DolphinView's url itself has to be set, that implies setting the url of the VMC. Correcting this makes the showEvent() hack unnecessary.


  dolphin/src/views/dolphinview.h 48967e6 
  dolphin/src/views/dolphinview.cpp 681ce74 





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list