Review Request: Locale-independent parsing of floats in trader queries

[Nicolas Alvarez]

> On July 10, 2011, 11:27 p.m., Nicolas Alvarez wrote:
> >

okay... reviewboard ate my message. Trying again:

Note that flex (.l) files are used to generate C/C++ source code, but that's *not* being done at build time. You'll have to manually update lex.c when committing this change.

(I tried fixing this and making all flex/bison get generated at compile time, but I ran into some CMake compatibility problems, so I think it'll have to wait for the next source-compat break...)


- Nicolas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101610/#review4582
-----------------------------------------------------------


On July 10, 2011, 7:39 a.m., Chusslove Illich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101610/
> -----------------------------------------------------------
> 
> (Updated July 10, 2011, 7:39 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Usage of atof() to parse floats in trader language was locale-dependent:
> if locale specified something other than dot as decimal separator,
> parsing floats (which are always dot-separated in queries) failed.
> Replaced atof() with simple sufficient custom parser.
> 
> Added a unit test.
> 
> 
> This addresses bug 275548.
>     http://bugs.kde.org/show_bug.cgi?id=275548
> 
> 
> Diffs
> -----
> 
>   kdecore/services/lex.l b00013b 
>   kdecore/tests/kservicetest.h 189bbd4 
>   kdecore/tests/kservicetest.cpp 8d14213 
> 
> Diff: http://git.reviewboard.kde.org/r/101610/diff
> 
> 
> Testing
> -------
> 
> Unit test.
> 
> In bug #275548 a plugin could not be loaded in some locales because,
> as it turned out, it failed version check due to misparsed floats
> in a trader query. This fix makes it load properly.
> 
> 
> Thanks,
> 
> Chusslove
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110710/0ce81de2/attachment.htm>