Review Request: Changed KUrl::toLocalFile to use QUrl::path() instead QUrl::toLocalFile() on non-Windows platforms

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101906/
-----------------------------------------------------------

(Updated July 10, 2011, 3:34 p.m.)


Review request for kdelibs and David Faure.


Changes
-------

Updated patch so that the previous behavior is not affected for non-local URLs.


Summary
-------

The attached patch changes KUrl::toLocalFile to use QUrl::path() when extracting the path from the current URL on non-Windows platforms so that KUrl would return the correct path when KUrl::toLocalFile is called on an absolute path url whose top level contains a ':', e.g. "file:///A:/".


This addresses bug 194746.
    http://bugs.kde.org/show_bug.cgi?id=194746


Diffs (updated)
-----

  kdecore/io/kurl.cpp acfc9a1 

Diff: http://git.reviewboard.kde.org/r/101906/diff


Testing
-------


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110710/13bfe64c/attachment.htm>