Review Request: konqueror: reset URL when pressing ESC in address bar

[Marcel Partap]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6681/
-----------------------------------------------------------

(Updated July 4, 2011, 11:29 p.m.)


Review request for kdelibs and David Faure.


Changes
-------

Patch v4, slimmed down to bare simplicity.
> The URL restored needs to be what was originally entered when the page was rendered.
> For example, if I typed "about:plugins" to view the available plugins, then typed another
> address and pressed escape, the address I expect to see is "about:blank" and not a
> blank location bar, which unfortunately is what this patch will result in.
Actually, I don't think so. To hide the real URL for about:konqueror and about:blank on initial opening is ok, but if you press ESCAPE, you get the current view's real URL. Imho that makes more sense than adding another variable to track the originally entered URL, which would complicate this simply beyond any sanity to catch and differentiate all corner cases.


Summary
-------

Attempted patch to make konqueror reset the URL when escape is pressed in the address bar. For reasons beyond my grokledge does not always seem to work.


This addresses bug 257841.
    https://bugs.kde.org/show_bug.cgi?id=257841


Diffs (updated)
-----

  /trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp 1200388 

Diff: http://svn.reviewboard.kde.org/r/6681/diff


Testing
-------

see https://bugs.kde.org/show_bug.cgi?id=257841#c0


Thanks,

Marcel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110704/1d6edc34/attachment.htm>