Review Request: Export the function isShiftAsModifierAllowed() from KKeySequenceWidget

Simon Persson simonpersson1 at gmail.com
Sat Jul 2 12:56:59 BST 2011


On Thursday 30 June 2011 02.39.01 Michael Jansen wrote:
> > 
> > I forgot that there's a kglobalaccel in kdelibs when I wrote the
> > summary.. therefore I didn't specify that this function is needed by 
> > the daemon kglobalaccel from kde-runtime.
> > 
> > I went ahead and commited today, in retrospect I should probably have
> > written this email first...
> > Let me know if you still have concerns regarding this!
> 
> We could move the code to KKeyServer . It does not feel complete right to
> be there but better than the widget.
> 
> Mike

Yep, I agree.  I just commited patches to move it.

Simon




More information about the kde-core-devel mailing list