Review Request: Add extraction scripts for translatable strings from Grantlee templates

Albert Astals Cid aacid at kde.org
Sat Jan 22 19:47:51 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6405/#review9679
-----------------------------------------------------------


The names of the scripts are too generic for what they do, can you please make them less generic?

- Albert


On Jan. 22, 2011, 7:33 p.m., Stephen Kelly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6405/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2011, 7:33 p.m.)
> 
> 
> Review request for kdelibs, Pino Toscano and Chusslove Illich.
> 
> 
> Summary
> -------
> 
> The new scripts allow the kde i18n infrastructure to extract translatable strings from Grantlee templates.
> 
> An additional line is needed in the Messages.sh script
> 
> 
> Diffs
> -----
> 
>   /home/kde-devel/kdesvn/trunk/KDE/kdesdk/scripts/extract_strings_gettext.py PRE-CREATION 
>   /home/kde-devel/kdesvn/trunk/KDE/kdesdk/scripts/strings_extractor.py PRE-CREATION 
>   /home/kde-devel/kdesvn/trunk/KDE/kdesdk/scripts/strings_extractor_gettext.py PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/6405/diff
> 
> 
> Testing
> -------
> 
> Works locally. The code in playground/pim/contacts can be used to test this with x-test once it's checked in.
> 
> 
> Thanks,
> 
> Stephen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110122/3b239695/attachment.htm>


More information about the kde-core-devel mailing list