kdewebkit fails to build with Mobile profile in trunk

[Alexis Ménard]

On Wed, Jan 12, 2011 at 4:18 AM, Kevin Ottens <ervin at kde.org> wrote:
> On Tuesday 11 January 2011 21:49:09 Dawit A wrote:
>> On Tue, Jan 11, 2011 at 12:55 PM, Kevin Ottens <ervin at kde.org> wrote:
>> > On Tuesday 11 January 2011 02:31:35 Marijn Kruisselbrink wrote:
>> >> [1]
>> >> https://build.pub.meego.com/package/view_file?file=02_kdelibs_compile.pa
>> >> tch
>> >> &package=kdelibs&project=home%3Amkruisselbrink%3Akde&srcmd5=20a6530bdfd
>> >> d79b d06c3ace11c7f0f96
>> >
>> > Anyone with that issue could test the attached patch instead please?
>> > Anne- Marie pointed out that it apparently workarounds the problem for
>> > her for some reason. You might need to make a clean build, or at least
>> > remove the corresponding moc files.
>> >
>> > I'm not a huge fan of randomly adding include files, but that one seems
>> > harmless enough compared to the issue of having that randomly failing
>> > build...
>>
>> Specially since the "kdewebkit_export.h" include already has
>> "kdemacros.h" in it...
>
> I agree it doesn't really make sense, but that's the patch Anne-Marie sent me
> a while back and apparently was fixing the issue for her. Since I don't
> experience said issue I can't confirm it workaround the problem. But it seems
> that for her it makes a difference in the code generated by moc.

Not sure it helps/related but in kdewebkit_export.h

# if defined(KDELIBS_STATIC_LIBS)

is not supported by moc. moc doesn't expand the macros for defined()
if I recall correctly

The problem exists in webkit too.

>
> Regards.
> --
> Kévin Ottens, http://ervin.ipsquad.net
>
> KDAB - proud patron of KDE, http://www.kdab.com
>