Review Request: Use UDS_NAME as a fallback when sorting via UDS_DISPLAY_NAME

Sebastian Trueg trueg at kde.org
Mon Jan 10 10:24:49 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6322/
-----------------------------------------------------------

Review request for kdelibs and Peter Penz.


Summary
-------

When sorting by name KDirSortFilterProxyModel uses UDS_DISPLAY_NAME. The latter, however, is not unique. This results in strange GUI behaviour like swapping items. This patch makes the model fall back to UDS_NAME to ensure a fixed sort order.
I also propose to backport it to 4.6.


Diffs
-----

  trunk/KDE/kdelibs/kfile/kdirsortfilterproxymodel.cpp 1211983 

Diff: http://svn.reviewboard.kde.org/r/6322/diff


Testing
-------


Thanks,

Sebastian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110110/322520f3/attachment.htm>


More information about the kde-core-devel mailing list