About remove nfs filesharing support

Rodrigo Belém rclbelem at gmail.com
Sun Jan 9 01:26:09 GMT 2011

I just sent the *initial* patch to http://reviewboard.kde.org/r/6308/.
It lacks username permission handling, disabling widgets when samba
share checkbox in unmarked, ui polishing and more :-) The patch
already removes the nfs support from the plugin.

2011/1/8 Rodrigo Belém <rclbelem at gmail.com>:
> On Wed, Jan 5, 2011 at 1:40 PM, Oswald Buddenhagen <ossi at kde.org> wrote:
>> On Tue, Dec 28, 2010 at 10:29:14PM -0400, Rodrigo Belém wrote:
>>> On Tue, Dec 28, 2010 at 12:05 PM, Kevin Krammer <kevin.krammer at gmx.at> wrote:
>>> > One code level nitpick: use of magic UID number 1000. In case this is some
>>> > kind of standard there is certainly a header specifying a constant/macro for
>>> > it. If not this looks kind of operating system or maybe even vendor specific.
>>> >
>>> This number needs to be discovered, but I hardcoded it just to get it
>>> working :-)
>> kcm_kdm and genkdmconf have code which (probably - i didn't look at your
>> patch) serves the same purpose. it should be probably centralized
>> somehow.
> Thanks Oswald, I had no idea where to look for it. I think that it
> should be centralized in KUser. What do you think?

More information about the kde-core-devel mailing list