Review Request: KFilePlacesView: Allow to add custom actions to the context menu

[Peter Penz]

> On 2011-01-04 17:30:53, Kevin Ottens wrote:
> > /trunk/KDE/kdelibs/kfile/kfileplacesview.cpp, line 638
> > <http://svn.reviewboard.kde.org/r/6267/diff/2/?file=43428#file43428line638>
> >
> >     Instead of introducing new API what about reusing QWidget::actions() here? Then on the dolphin side it's just a addActions() call away.

I'm of course fine with this approach too. As you said currently only Dolphin requires this and adding a dedicated API for this might be overkill... I've just committed the one-liner patch to trunk.


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6267/#review9519
-----------------------------------------------------------


On 2011-01-03 20:32:14, Peter Penz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6267/
> -----------------------------------------------------------
> 
> (Updated 2011-01-03 20:32:14)
> 
> 
> Review request for kdelibs and Kevin Ottens.
> 
> 
> Summary
> -------
> 
> For KDE SC 4.7 Dolphin allows to lock/unlock the panels (= QDockWidgets) like in Amarok. Beside having a menu entry in the menu under "View" the dual-action "Lock Panels"/"Unlock Panels" is also provided as context menu entry for all panels.
> 
> All panels have this menu-entry already, but the places panel is implemented as KFilePlacesView which currently does not allow to add custom actions to the context menu.
> 
> The attached patch extends KFilePlacesView by this (see screenshot, where the action "Unlock Panels" has been added).
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kfile/kfileplacesview.h 1211329 
>   /trunk/KDE/kdelibs/kfile/kfileplacesview.cpp 1211329 
> 
> Diff: http://svn.reviewboard.kde.org/r/6267/diff
> 
> 
> Testing
> -------
> 
> Tested in Dolphin by adding the actions "Unlock Panels"/"Lock Panels".
> 
> 
> Screenshots
> -----------
> 
> Context menu with custom action "Unlock Panels"
>   http://svn.reviewboard.kde.org/r/6267/s/600/
> 
> 
> Thanks,
> 
> Peter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110104/4927b860/attachment.htm>