Review Request: [PATCH] Make KIO::Scheduler correctly re-use ioslaves that have been put on hold...

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6271/
-----------------------------------------------------------

(Updated 2011-01-04 09:55:29.299913)


Review request for kdelibs.


Changes
-------

Correct patch...


Summary
-------

The patch attempts to fix the following two oustanding problems in KIO::Scheduler that have been around for a while (see the possibly related bug reports in the Bugs section above):

#1. Set the m_checkOnHold flag to true every time Scheduler::publishSlaveOnHold is invoked. Right now that flag is only set to true when an instance of KIO::Scheduler is created. This results in the flag never being true after the first ioslave has been put on hold and reused unless the programmer explicitly calls KIO::Scheduler::checkSlaveOnHold which is not documented at all. See the description about putting ioslaves on hold in KIO::get's API documentation.

#2. Modify SchedulerPrivate::doJob to correctly set the m_checkOnHold flag for http requests when a job's command is CMD_SPECIAL.  That is necessary because HTTP_POST, which is handled as a special command, can return content just like a get request.


This addresses bugs 123121 and 148307.
    https://bugs.kde.org/show_bug.cgi?id=123121
    https://bugs.kde.org/show_bug.cgi?id=148307


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kio/kio/scheduler.cpp 1211439 

Diff: http://svn.reviewboard.kde.org/r/6271/diff


Testing
-------


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110104/c046a989/attachment.htm>