Review Request: KFilePlacesView: Allow to add custom actions to the context menu

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6267/
-----------------------------------------------------------

(Updated 2011-01-03 20:32:14.648343)


Review request for kdelibs and Kevin Ottens.


Changes
-------

Use menu.addActions(...) instead of using foreach + menu.addAction(...) as suggested by Christoph.


Summary
-------

For KDE SC 4.7 Dolphin allows to lock/unlock the panels (= QDockWidgets) like in Amarok. Beside having a menu entry in the menu under "View" the dual-action "Lock Panels"/"Unlock Panels" is also provided as context menu entry for all panels.

All panels have this menu-entry already, but the places panel is implemented as KFilePlacesView which currently does not allow to add custom actions to the context menu.

The attached patch extends KFilePlacesView by this (see screenshot, where the action "Unlock Panels" has been added).


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kfile/kfileplacesview.h 1211329 
  /trunk/KDE/kdelibs/kfile/kfileplacesview.cpp 1211329 

Diff: http://svn.reviewboard.kde.org/r/6267/diff


Testing
-------

Tested in Dolphin by adding the actions "Unlock Panels"/"Lock Panels".


Screenshots
-----------

Context menu with custom action "Unlock Panels"
  http://svn.reviewboard.kde.org/r/6267/s/600/


Thanks,

Peter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110103/3d3ffa5e/attachment.htm>