Review Request: Add support for building libplasma with GLES2

Jammy Zhou jammy.zhou at linaro.org
Fri Feb 25 03:29:36 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100705/
-----------------------------------------------------------

(Updated Feb. 25, 2011, 3:29 a.m.)


Review request for kdelibs and Plasma.


Changes
-------

Update the patch to remove direct OpenGL dependency for libplasma. The OpenGL usage in libplasma should better go through libQtOpenGL,which can be enabled for desktop OpenGL or OpenGL ES2.0


Summary
-------

After build kwin with GLES2 code path, the kwin binary still has dependency on libGL.so, which is introduced by libplasma.so. Then we also need to add GLES2 support to libplasma, so that kwin/plasma only has dependency on libGLESv2.so in this case. 

The new option "BUILD_PLASMA_WITH_OPENGLES" added in attached patch is disabled by default, and distributions can turn it on when do packaging for OpenGL ES2.0 support.


Diffs (updated)
-----

  CMakeLists.txt b8d53de 
  includes/CMakeLists.txt 9954c37 
  plasma/CMakeLists.txt 8e6b0d7 
  plasma/glapplet.cpp 00d7caf 

Diff: http://git.reviewboard.kde.org/r/100705/diff


Testing
-------

After turn the "BUILD_PLASMA_WITH_OPENGLES" option on, kwin-gles has no dependency on libGL.so now. And by default, libplasma still depends on libGL.so when run ldd.


Thanks,

Jammy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110225/e7b4545e/attachment.htm>
-------------- next part --------------
_______________________________________________
Plasma-devel mailing list
Plasma-devel at kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


More information about the kde-core-devel mailing list