Review Request: Can't switch back to laptop display when external display gets disconnected

[alter_schwede at bossmail.de]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6513/
-----------------------------------------------------------

(Updated Feb. 20, 2011, 1:48 a.m.)


Review request for kdelibs and usability.


Changes
-------

I think it's better to read/understand now.


Summary
-------

I already posted this patch here:
https://bugs.kde.org/show_bug.cgi?id=265955

This is a patch to the kded_randrmonitor service that solves the below
mentioned problem.
If only one output is connected and the user tries to switch the display it
makes sure the connected output gets activated and deactivates all disconnected
output afterwards.

Reproducible: Always

Steps to Reproduce:
1. Connect an external display to your laptop and use your latop's hotkey (e.g.
Fn+F6) to active it and deactivate your laptop's display.
2. Disconnect the external display
3. Try to switch back to internal display with your keyboard

Actual Results:  
Nothing happens
----
I improved my patch.
Now it also automatically deactivates all disconnected outputs on resume from
suspend and switches to a connected monitor if needed. This should fix e.g. Bug
#257642.


This addresses bugs 257642 and 265955.
    https://bugs.kde.org/show_bug.cgi?id=257642
    https://bugs.kde.org/show_bug.cgi?id=265955


Diffs (updated)
-----

  /branches/KDE/4.6/kdebase/workspace/kcontrol/randr/module/randrmonitor.h 1221086 
  /branches/KDE/4.6/kdebase/workspace/kcontrol/randr/module/randrmonitor.cpp 1221086 

Diff: http://svn.reviewboard.kde.org/r/6513/diff


Testing
-------


Thanks,

alter_schwede

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110220/6e1c39f7/attachment.htm>