Review Request: Implement a dialog to show unhandled Bugzilla errors

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100681/#review1501
-----------------------------------------------------------

Ship it!


Hey, thanks for the patch. I didn't expect you to suddenly appear and implement this in such a short time, but I am glad that you did. I only have some minor comments to make. You know this code better than me anyway, so I trust it does the right thing.


drkonqi/reportassistantpages_bugzilla.cpp
<http://git.reviewboard.kde.org/r/100681/#comment1270>

    Why i18nc with an empty context? i18n("Save to a file") should work.



drkonqi/reportassistantpages_bugzilla.cpp
<http://git.reviewboard.kde.org/r/100681/#comment1272>

    Is there a specific reason to use QPointer here? KFileDialog* would also work fine. I am mostly saying this because QPointer is kind of deprecated in favor of QWeakPointer now...



drkonqi/reportassistantpages_bugzilla.cpp
<http://git.reviewboard.kde.org/r/100681/#comment1271>

    There is an unecessary extra space in the translated string here.


- George


On Feb. 19, 2011, 12:34 a.m., Darío Andrés Rodríguez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100681/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2011, 12:34 a.m.)
> 
> 
> Review request for KDE Runtime and George Kiagiadakis.
> 
> 
> Summary
> -------
> 
> Initial patch
> 
> I created a dialog that will show the RAW Bugzilla HTML output when the response can't be parsed by DrKonqi. The user is encouraged to perform the action again later or save the HTML data to submit a DrKonqi bug.
> 
> This function is available for the login and the submit (new report or attach to an existant one) processes.
> BugzillaLib error message signals were enhanced to hold the raw html (if it makes sense to show it)
> 
> The text on the dialog could be changed.
> 
> Additional fix: disconnect signals prior to creating a new report or attaching to an existing one; avoiding duplicates dialog. (may be this should go as another patch)
> 
> 
> This addresses bug 266542.
>     http://bugs.kde.org/show_bug.cgi?id=266542
> 
> 
> Diffs
> -----
> 
>   drkonqi/CMakeLists.txt 87c3d24 
>   drkonqi/bugzillalib.h cb7da10 
>   drkonqi/bugzillalib.cpp 348fb72 
>   drkonqi/reportassistantpages_bugzilla.h 8681f22 
>   drkonqi/reportassistantpages_bugzilla.cpp e896c52 
>   drkonqi/reportinterface.h a1fc78a 
>   drkonqi/reportinterface.cpp a484d11 
> 
> Diff: http://git.reviewboard.kde.org/r/100681/diff
> 
> 
> Testing
> -------
> 
> Tested by faking some errors during the login and submit (new report) processes.
> The code should be reviewed as I stop coding for KDE several months ago.
> 
> 
> Screenshots
> -----------
> 
> Unhandled Error Dialog
>   http://git.reviewboard.kde.org/r/100681/s/77/
> 
> 
> Thanks,
> 
> Darío Andrés
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110219/faccf5bf/attachment.htm>