KJob::Capabilities and KWidgetJobTracker

[Kevin Ottens]

On Wednesday 9 February 2011 19:21:26 Matthias Fuchs wrote:
> Am Mittwoch 09 Februar 2011, 19:06:41 schrieb Kevin Ottens:
> > On Wednesday 9 February 2011 18:52:57 Matthias Fuchs wrote:
> > > I wonder wether setting capabilties for KJobs should be "required".
> > > Currently you are presented with a "Pause" button in KWidgetJobTracker,
> > > even if the job does _not_ have the Suspendable capability.
> > 
> > Isn't it more a problem of the tracker not querying the capabilities()
> > when it gets passed a job and adapting it's UI accordyingly? That's
> > actually one of the intended use cases for the capabilities() method in
> > KJob.
> 
> Partially, but what happens if the capabilities change?

Right now, none of our jobs change capabilities once started. We never had the 
need previously, now we can extend that if needed. In which case the signal 
approach you propose seems sound to me.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud patron of KDE, http://www.kdab.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110209/c15a393b/attachment.sig>