Review Request: Clearing scrollback and resetting does not present a new prompt

José Manuel Santamaría Lema panfaust at gmail.com
Tue Feb 8 21:16:20 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100611/
-----------------------------------------------------------

Review request for Konsole.


Summary
-------

Hi,

I can reproduce bug #242110 here, so I fixed it. Note that commit 5d61b69e3e6a0348b04a0848a7080f748b36eb6e re-added "Clear ScrollBack and Reset". This commit introduced _session->refresh(); commented out. I have checked the previous, different implementation from 4.4 branch and that implementation called _session->refresh() so I guess it must be commented out by accident.


This addresses bug 242110.
    http://bugs.kde.org/show_bug.cgi?id=242110


Diffs
-----

  src/SessionController.cpp a5d4019 

Diff: http://git.reviewboard.kde.org/r/100611/diff


Testing
-------

I reproduced the bug and tested the patch installing from not-yet-released debian packages for KDE SC 4.6 (I'm working on them among other people).


Thanks,

José Manuel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110208/3c21d16c/attachment.htm>


More information about the kde-core-devel mailing list