Review Request: Prevent KHTML's adblock filter parser from incorrectly parsing rules with options...

Dawit Alemayehu adawit at
Sun Feb 6 16:07:27 GMT 2011

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 6, 2011, 4:07 p.m.)

Review request for kdelibs.


This request is created because no one from the KHTML developerment team responded to my post in kfm-devel. Basically this patch prevents the FilterSet::addFilter function in khtml_filter.cpp from incorrectly interpreting a rule with options such as *$image,~image,donottrack as the wildcard matching "*". Obviously doing that causes every request processed to be matched and hence blocked. The above rule was extracted from a recent version of Easy Privacy + EasyList filter. Here the relevant snippet:

[Adblock Plus 1.1]
! Checksum: BjTRSfga8mRDTYGW3UpIDQ
! EasyPrivacy and EasyList combination subscription
! Last modified: 29 Jan 2011 18:30 UTC
! *** easyprivacy.txt ***
! EasyPrivacy -
! Expires: 5 days (update frequency)
! Licence:
! Please report any unblocked tracking or problems
! in the forums (
! or via e-mail (easylist.subscription at
!-----------------The X-Do-Not-Track header-----------------!
*$image,~image,donottrack                                                        <==================== RULE THAT CAUSES THE PROBLEM
!-----------------General tracking systems-----------------!
! *** easyprivacy/easyprivacy_general.txt ***

If you do not have this patch and you activate adblocking with the EasyPrivacy + Easy List filter selected, then the images will be missing when Konqueror's default page (about:konqueror) is shown.


  khtml/khtml_filter.cpp dc3d0f50b 


Testing (updated)

Tested by applying the patch and seeing that Konqueror correctly renders the default about page.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list