Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

[Thiago Macieira]

Em sexta-feira, 4 de fevereiro de 2011, às 05:24:26, Dawit A escreveu:
> > In the meantime, I've been discussing with Rémi about the issue and he's
> > not budging from his position that libraries shoul
> >  never use Unix signals. To be
> > honest, he's right: Unix signals are meant to be used centrally only.
> > But we need SIGCHLD to be notified that a child exited, so we need a
> > compromise between apps and libraries.
> 
> That is especially true for QProcess. It is used in several place
> within kdelibs. If any of those code paths are hit from an app like
> VLC, the same issue will manifest itself as well. I am still wondering
> whether or not the QtCreator freeze I get to this day is somehow
> related to this issue even though I doubt QtCreator does any signal
> blocking...

Qt workaround patch.

I will most definitely not add this to 4.7. I will show to other engineers in 
the office and we'll consider 4.8.

http://qt.pastebin.com/U6dF8kzd

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Product Manager - Nokia, Qt Development Frameworks
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: download.php
Type: text/x-diff
Size: 13618 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110204/a0be9acb/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110204/a0be9acb/attachment.sig>