Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

[Dawit Alemayehu]

> On Feb. 4, 2011, 10:54 a.m., Pino Toscano wrote:
> > Still the coding style issues to fix in the new code.

Sorry, but I do not see that as an issue...


> On Feb. 4, 2011, 10:54 a.m., Pino Toscano wrote:
> > kdecore/services/kmimetyperepository.cpp, lines 688-689
> > <http://git.reviewboard.kde.org/r/100539/diff/7/?file=8344#file8344line688>
> >
> >     Q_OS_UNIX here (and comment updated for "Unix")

Not really. It is pointless to add a path that is meaningless in *BSD. Anyhow, I have fixed the #ifdef to be more robust. It will now use the Linux arch-independent path for all linux and as a fall back for the remaining unix flavors.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100539/#review1199
-----------------------------------------------------------


On Feb. 4, 2011, 10:11 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100539/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2011, 10:11 a.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> The attached patch is a workaround to the much discussed issue with VLC hanging when opening a KDE file dialog. For the details about the causes of this bug, see http://lists.kde.org/?t=129572447500001&r=1&w=2 and the bug report linked above...
> 
> 
> This addresses bug 260719.
>     http://bugs.kde.org/show_bug.cgi?id=260719
> 
> 
> Diffs
> -----
> 
>   kdecore/services/kmimetyperepository.cpp 9f4c3ca 
> 
> Diff: http://git.reviewboard.kde.org/r/100539/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110204/44a8a4ab/attachment.htm>