Review Request: New KIO::http_post and KIO::StoredHttpPost APIs that accept a QIODevice as input...

Allan Sandfeld Jensen kde at carewolf.com
Fri Feb 4 12:12:37 GMT 2011


Is QIODevice the best idea to use as source?

Since we are talking KIO, I believe we can espect the user of KIO::http_post 
to be using KIO and not Qt IO. So would it instead be possible to make the 
source a KIO job or KUrl?

Regards
`Allan

On Wednesday 02 February 2011, Dawit Alemayehu wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100516/
> -----------------------------------------------------------
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> The attached patch is the first portion a set of patches to make uploading
> data through HTTP more efficient without affecting the existing
> implementation. Right now the amount of memory consumed when uploading
> large files through http or webdav is really not acceptable because only a
> QByteArray based API is available. That means if you want to upload a file
> of say 50 or 100 MB to a server, then you have to read the entire thing
> first before you can call KIO::http_post!
> 
> 
> This addresses bug 34578.
>     http://bugs.kde.org/show_bug.cgi?id=34578
> 
> 
> Diffs
> -----
> 
>   kio/kio/jobclasses.h e9bd191
>   kio/kio/job_p.h daac895
>   kio/kio/job.cpp 7d4a849
>   kio/kio/job.h 632dfc8
> 
> Diff: http://git.reviewboard.kde.org/r/100516/diff
> 
> 
> Testing
> -------
> 
> Used by changing kdewebkit to use the new API.
> 
> 
> Thanks,
> 
> Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110204/325ad2a5/attachment.htm>


More information about the kde-core-devel mailing list