Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

[Pino Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100539/#review1190
-----------------------------------------------------------


Please also add the { } around single line blocks (as per kdelibs coding style).


kdecore/services/kmimetyperepository.cpp
<http://git.reviewboard.kde.org/r/100539/#comment1004>

        QStringList paths;
        const QByteArray pkgConfigPath = qgetenv("PKG_CONFIG_PATH");
        if (!pkgConfigPath.isEmpty())
            paths << QFile::decodeName(pkgConfigPath).split(QLatin1Char(':'), QString::SkipEmptyParts);
    
        paths << QLatin1String("/usr/share/pkgconfig");
    


- Pino


On Feb. 4, 2011, 1:29 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100539/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2011, 1:29 a.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> The attached patch is a workaround to the much discussed issue with VLC hanging when opening a KDE file dialog. For the details about the causes of this bug, see http://lists.kde.org/?t=129572447500001&r=1&w=2 and the bug report linked above...
> 
> 
> This addresses bug 260719.
>     http://bugs.kde.org/show_bug.cgi?id=260719
> 
> 
> Diffs
> -----
> 
>   kdecore/services/kmimetyperepository.cpp 9f4c3ca 
> 
> Diff: http://git.reviewboard.kde.org/r/100539/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110204/291e35fc/attachment.htm>