Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

[Pino Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100539/#review1186
-----------------------------------------------------------



kdecore/services/kmimetyperepository.cpp
<http://git.reviewboard.kde.org/r/100539/#comment992>

    This is:
    - assuming the PKG_CONFIG_PATH envvar it is set (which is not mandatory)
    - using the arch-dependent path of pkg-config, while the "shared-mime-info" database is considered arch-independent (so being in $prefix/share/pkgconfig)



kdecore/services/kmimetyperepository.cpp
<http://git.reviewboard.kde.org/r/100539/#comment993>

    Instead of using findExe on the path string ignoring the exec permissions, wouldn't be easier to just loop over the paths (which would be then built as list) and check for the existance of the shared-mime-info.pc file?
    findExe() would also look in the "exe" paths, but in those there's no shared-mime-info.pc file for sure.



kdecore/services/kmimetyperepository.cpp
<http://git.reviewboard.kde.org/r/100539/#comment996>

    I guess a slightly more efficient approach (yet a bit more verbose) would be reading line by line (as QByteArray, so no conversion) the file, and if one starts with "Version:",  convert it fromLocal8Bit() and apply the regexp.



kdecore/services/kmimetyperepository.cpp
<http://git.reviewboard.kde.org/r/100539/#comment995>

    no need for trailing "..." or ",,," in every sentence :)



kdecore/services/kmimetyperepository.cpp
<http://git.reviewboard.kde.org/r/100539/#comment994>

    I don't see a QRegExp constructor taking directly a QLatin1String, so why this change?


- Pino


On Feb. 3, 2011, 11:23 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100539/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2011, 11:23 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> The attached patch is a workaround to the much discussed issue with VLC hanging when opening a KDE file dialog. For the details about the causes of this bug, see http://lists.kde.org/?t=129572447500001&r=1&w=2 and the bug report linked above...
> 
> 
> This addresses bug 260719.
>     http://bugs.kde.org/show_bug.cgi?id=260719
> 
> 
> Diffs
> -----
> 
>   kdecore/services/kmimetyperepository.cpp 9f4c3ca 
> 
> Diff: http://git.reviewboard.kde.org/r/100539/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110203/3eee621e/attachment.htm>