Review Request: Do not add two actions with the same name to Konqueror's actionCollection.

Dawit Alemayehu adawit at kde.org
Fri Dec 30 23:08:06 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103590/
-----------------------------------------------------------

Review request for KDE Base Apps and David Faure.


Description
-------

The attached patch fixes the problem of not being able to change the shortcut key for the "Show Terminal Emulator" action by adding "-viewmode" to the desktopEntryName used as the first parameter when the action is added to actionCollection(). That way two actions with the same name "konsolepart" won't overwrite each other.


This addresses bug 266517.
    http://bugs.kde.org/show_bug.cgi?id=266517


Diffs
-----

  konqueror/src/konqmainwindow.cpp 3b6e418 

Diff: http://git.reviewboard.kde.org/r/103590/diff/diff


Testing
-------

Launch the shortcut configuration dialog before and after the patch in filenmanagement mode.


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111230/afbc5404/attachment.htm>


More information about the kde-core-devel mailing list