Review Request: Make kfmclient honor the user configured browser settings for local resources

Dawit Alemayehu adawit at kde.org
Sat Dec 24 22:16:26 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103524/
-----------------------------------------------------------

(Updated Dec. 24, 2011, 10:16 p.m.)


Review request for KDE Base Apps and David Faure.


Changes
-------

Updated patch.


Description
-------

The attached patch changes kfmclient so that it

* honors the user configured browser setting when the specified URL is a local page that is to be handled by a browser.
* honors the user configured browser setting when the user specified url is ftp.


This addresses bug 182591.
    http://bugs.kde.org/show_bug.cgi?id=182591


Diffs (updated)
-----

  konqueror/client/kfmclient.cpp 339ba31 

Diff: http://git.reviewboard.kde.org/r/103524/diff/diff


Testing
-------

Change the browser in the default application list to "firefox" and make sure all of the following commands open the URL in firefox:

* kfmclient openURL http://www.kde.org 
* kfmclient openURL /usr/share/doc/qt/html/index.html
* kfmclient openURL ftp://ftp.kde.org


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111224/cd107fa6/attachment.htm>


More information about the kde-core-devel mailing list