Review Request: Reset time format upon user request
Commit Hook
null at kde.org
Thu Dec 22 13:24:05 GMT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103434/#review9163
-----------------------------------------------------------
This review has been submitted with commit 68ec5f077e20afe09def364d6e76ecbe989db02d by Lamarque V. Souza to branch ksmserver/qml-shutdowndlg.
- Commit Hook
On Dec. 19, 2011, 2:03 p.m., Lamarque Vieira Souza wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103434/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2011, 2:03 p.m.)
>
>
> Review request for kdelibs and Plasma.
>
>
> Description
> -------
>
> The patch resets time format in digital clock plasmoid when the user changes the 24h configuration in active-settings.
>
> The reset part is from kdelibs/kdecore/localization/klocale_kde.cpp. I am wondering if I should add this change to kdelibs instead of kde-workspace to avoid duplicating code. Anyway, I wanted someone to review the code to see if there can be any side effect.
>
>
> This addresses bug 289094.
> http://bugs.kde.org/show_bug.cgi?id=289094
>
>
> Diffs
> -----
>
> plasma/generic/applets/digital-clock/clock.h 4aec3fd
> plasma/generic/applets/digital-clock/clock.cpp dd03692
>
> Diff: http://git.reviewboard.kde.org/r/103434/diff/diff
>
>
> Testing
> -------
>
> Works in Plasma Active. In Plasma Desktop kcmlocale does not call KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged) so it does not take effect. Other kcm modules (e.g. keyboard), call emitChange.
>
>
> Thanks,
>
> Lamarque Vieira Souza
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111222/984c76d3/attachment.htm>
-------------- next part --------------
_______________________________________________
Plasma-devel mailing list
Plasma-devel at kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
More information about the kde-core-devel
mailing list